RFR: 8320796: CssMetaData.combine() [v4]

[Kevin Rushforth]

On Tue, 28 Nov 2023 20:14:13 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Nir was probably referring to the type of the `list` parameter.
>> As for the return value, not only must this be a `List`, it should also be mandated to be `RandomAccess`. Any implementation that doesn't support random access may cause severe performance degradation.
>
> Right.  The `list` argument *could* be a Collection, but I wanted to narrow down the scope of this utility to combining parent's and child's styleables in one efficient call.  I thought having it accept a List (as returned by {Parent}.getClassCssMetaData()) and not some random Collection might be a better design.

I'd leave it as is given the intended use cases.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1296#discussion_r1408493790