RFR: 8320796: CssMetaData.combine() [v4]

[Kevin Rushforth]

On Tue, 28 Nov 2023 18:45:01 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 333:
>> 
>>> 331:     /**
>>> 332:      * Utility method which combines {@code CssMetaData} items in one unmodifiable list with size equal
>>> 333:      * to the number of items it holds.
>> 
>> It is trivially true that the size of a list is equal to the number of its items, maybe you wanted to say "capacity"?
>> 
>> In any case, I don't think that this is relevant information (the list is unmodifiable, so its capacity is of no concern or use to the caller). However, I think you could say a word or two about why this method is here in the first place, namely to support implementing `getClassCssMetaData()`. Maybe even give a code sample of how to do it properly.
>
> +1 for code sample.

I like the idea of either removing the discussion about size (capacity, really), or maybe moving it to an `@implNote`. And yes, a sample seems like a good idea.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1296#discussion_r1408493229