RFR: 8320359: ImageView: add styleable fitWidth, fitHeight, preserveRatio, smooth properties

Michael Strauß mstrauss at openjdk.org
Thu Nov 30 16:53:24 UTC 2023


On Tue, 21 Nov 2023 00:01:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Adding missing styleable properties to ImageView:
> 
> 
> -fx-preserve-ratio
> -fx-smooth
> -fx-fit-width
> -fx-fit-height
> 
> 
> Updated CSS Reference.

Marked as reviewed by mstrauss (Committer).

modules/javafx.graphics/src/main/java/com/sun/javafx/css/CssUtil.java line 36:

> 34:  * Utility methods for dealing with CSS.
> 35:  */
> 36: public class CssUtil {

I think it's best for utility classes to make it `final` and the constructor `private`.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1293#pullrequestreview-1757936512
PR Review Comment: https://git.openjdk.org/jfx/pull/1293#discussion_r1410960138


More information about the openjfx-dev mailing list