RFR: 8306083: Text.hitTest is incorrect when more than one Text node in TextFlow [v7]

Karthik P K kpk at openjdk.org
Tue Oct 3 10:03:04 UTC 2023


On Wed, 20 Sep 2023 17:40:58 GMT, Phil Race <prr at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java line 760:
> 
>> 758:         int lineCount = getLineCount();
>> 759:         while (index < lineCount) {
>> 760:             if (text != null) {
> 
> why aren't you using "textFound" as in if "(!textFound) {"

Updated code to use `textFound`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1157#discussion_r1343838434


More information about the openjfx-dev mailing list