Integrated: JDK-8316590: Rendering artifact after JDK-8311983

Marius Hanl mhanl at openjdk.org
Mon Oct 9 21:03:04 UTC 2023


On Thu, 21 Sep 2023 14:27:59 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

> Fixes the regression by basically reverting one change introduced in https://bugs.openjdk.org/browse/JDK-8311983.
> The problem is that it is actually required to get the size from a cell with the index -1, which technically does not exist (the accumCell is used then).
> 
> Furthermore, unlike the name suggests, the call to `addLeadingCells()` is always needed, even if there are none.
> This is because the method does much more than what you would think first. 
> 
> In future, it would probably be good to revisit this code. Also performance wise, since this looks like something that can be optimized. But that is another story, not related to this fix.

This pull request has now been integrated.

Changeset: ec9a11bc
Author:    Marius Hanl <mhanl at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/ec9a11bc2b5f2f01c3109a13ccc03274e8ed7678
Stats:     67 lines in 2 files changed: 62 ins; 1 del; 4 mod

8316590: Rendering artifact after JDK-8311983

Reviewed-by: jvos, kpk, angorya

-------------

PR: https://git.openjdk.org/jfx/pull/1246


More information about the openjfx-dev mailing list