RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v7]

Sai Pradeep Dandem duke at openjdk.org
Fri Oct 20 00:26:08 UTC 2023


> **Issue:**
> Using pseudo classes in programmatic query using Node.lookupAll() or Node.lookup() gives unexpected results.
> 
> **Cause:**
> There is no check for checking the psuedo states matching in the applies() method of SimpleSelector.java. So checking for "applies()" alone is not sufficient in lookup() method.
> 
> **Fix:**
> Included an extra check for the psuedo states to match.

Sai Pradeep Dandem has updated the pull request incrementally with two additional commits since the last revision:

 - 8185831: Minor change to remove extra line
 - 8185831: Added testcase to verify when the selector ignores pseudo classes when the nodes have same style class

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1245/files
  - new: https://git.openjdk.org/jfx/pull/1245/files/8fdbd416..5ab67a27

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1245&range=06
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1245&range=05-06

  Stats: 43 lines in 1 file changed: 42 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/1245.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1245/head:pull/1245

PR: https://git.openjdk.org/jfx/pull/1245


More information about the openjfx-dev mailing list