RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v7]

Andy Goryachev angorya at openjdk.org
Fri Oct 20 00:26:09 UTC 2023


On Fri, 20 Oct 2023 00:22:27 GMT, Sai Pradeep Dandem <duke at openjdk.org> wrote:

>> **Issue:**
>> Using pseudo classes in programmatic query using Node.lookupAll() or Node.lookup() gives unexpected results.
>> 
>> **Cause:**
>> There is no check for checking the psuedo states matching in the applies() method of SimpleSelector.java. So checking for "applies()" alone is not sufficient in lookup() method.
>> 
>> **Fix:**
>> Included an extra check for the psuedo states to match.
>
> Sai Pradeep Dandem has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8185831: Minor change to remove extra line
>  - 8185831: Added testcase to verify when the selector ignores pseudo classes when the nodes have same style class

modules/javafx.graphics/src/test/java/test/javafx/scene/Node_lookup_Test.java line 238:

> 236:         nodes = root.lookupAll(".x:random");
> 237:         assertEquals(0, nodes.size());
> 238: 

excellent!  thank you.
could you please remove the extra newline before } here ?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1245#discussion_r1366270276


More information about the openjfx-dev mailing list