RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation

Andy Goryachev angorya at openjdk.org
Thu Oct 26 15:33:51 UTC 2023


On Thu, 26 Oct 2023 09:34:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> FX Nodes embedded in a Swing JFXPanel does not track the component orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value from the JFXPanel.

modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 817:

> 815:             ComponentOrientation cor = this.getComponentOrientation();
> 816:             if (!cor.equals(ComponentOrientation.UNKNOWN)) {
> 817:                 String orient = cor.equals(ComponentOrientation.LEFT_TO_RIGHT)

Why a String??  Should it be a simple boolean?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1271#discussion_r1373366241


More information about the openjfx-dev mailing list