RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Oct 26 16:27:06 UTC 2023


On Thu, 26 Oct 2023 15:31:02 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Optimization
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 817:
> 
>> 815:             ComponentOrientation cor = this.getComponentOrientation();
>> 816:             if (!cor.equals(ComponentOrientation.UNKNOWN)) {
>> 817:                 String orient = cor.equals(ComponentOrientation.LEFT_TO_RIGHT)
> 
> Why a String??  Should it be a simple boolean?

Yes, Optimized...

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1271#discussion_r1373435929


More information about the openjfx-dev mailing list