RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v4]

[Kevin Rushforth]

On Mon, 30 Oct 2023 07:19:54 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Yes, you are right that JFXPanel needs to call into the stage and not the other way around. The general approach now looks correct, however, you'll need to add the orientation attribute on the JavaFX Window (`EmbeddedWindow`) not on the peer (`EmbeddedStage`). The other thing you will need is to to call `SceneHelper::parentEffectiveOrientationInvalidated` from `EmbeddedWindow::setOrientation` when the value of the orientation changes.
>
> I have made the suggested changes and updated the PR.
> But it seems the orientation of the text in the test attached in JBS is at the middle initially (and not at LTR or RTL) and it only begins to track the orientation after 1 iteration of changing JFrame orientation. Is it because of INHERIT default value which causes the effective orientation to not follow the changed orientation immediately? Does it need to be looked at or is it expected?

This might be due to the initialization problem I pointed out or it might be for some other reason. Can you make the suggested change and then re-test?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1271#discussion_r1376166175