RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v4]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Oct 30 14:00:57 UTC 2023
On Mon, 30 Oct 2023 12:53:07 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> I have made the suggested changes and updated the PR.
>> But it seems the orientation of the text in the test attached in JBS is at the middle initially (and not at LTR or RTL) and it only begins to track the orientation after 1 iteration of changing JFrame orientation. Is it because of INHERIT default value which causes the effective orientation to not follow the changed orientation immediately? Does it need to be looked at or is it expected?
>
> This might be due to the initialization problem I pointed out or it might be for some other reason. Can you make the suggested change and then re-test?
Yes, initialization helped..Updated the PR...
Also, speaking of regression test, I need some time to create one.. Will it be ok to push the fix if found to be ok and I work on the test simultaneously as a separate JBS test issue? Had it been jtreg I would have attempted it right way but FX test understanding will take some time be in manual or if possible in automated way..
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1271#discussion_r1376262611
More information about the openjfx-dev
mailing list