RFR: 8301302: Platform preferences API [v5]

[Kevin Rushforth]

On Tue, 5 Sep 2023 00:55:44 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Please read [this document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for an introduction to the Platform Preferences API, and how it interacts with the proposed style theme and stage appearance features.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed application preferences implementation

A couple minor comments. on the API docs. I'll do a more thorough review later.

modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 466:

> 464:      * so applications should not assume that a particular preference is always available.
> 465:      * <p>
> 466:      * The following list contains all preferences that are potentially available on the specified platforms:

Is it possible that a preference might be stored that isn't in the below list? Or is it guaranteed that the _only_ possible preferences that will ever be stored are those documented here? If the former, I recommend removing the word "all". If the latter, then it is OK as is, if we are comfortable specifying this.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1014#pullrequestreview-1611865735
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316367820