RFR: 8301302: Platform preferences API [v5]

Michael Strauß mstrauss at openjdk.org
Wed Sep 6 00:14:49 UTC 2023


On Tue, 5 Sep 2023 19:56:56 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed application preferences implementation
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/application/preferences/PlatformPreferencesTest.java line 41:
> 
>> 39: 
>> 40: import static org.junit.jupiter.api.Assertions.*;
>> 41: import static test.javafx.collections.MockMapObserver.Tuple.tup;
> 
> this generates 9 errors in eclipse, starting with
> 
> Description	Resource	Type
> The type test.javafx.collections.MockMapObserver.Tuple.tup is not accessible	PlatformPreferencesTest.java	Java Problem
> 
> the following  change to graphics/.classpath should fix it (inc. complete file):
> 
> 
> <?xml version="1.0" encoding="UTF-8"?>
> <classpath>
> 	<classpathentry kind="src" path="src/main/java"/>
> 	<classpathentry kind="src" path="build/gensrc/jsl-prism"/>
> 	<classpathentry kind="src" path="build/gensrc/jsl-decora"/>
> 	<classpathentry kind="src" path="build/hlsl/Decora"/>
> 	<classpathentry kind="src" path="build/hlsl/Prism"/>
> 	<classpathentry kind="src" output="testbin" path="src/shims/java">
> 		<attributes>
> 			<attribute name="test" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="src" output="testbin" path="src/test/java">
> 		<attributes>
> 			<attribute name="test" value="true"/>
> 			<attribute name="optional" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="src" path="src/main/resources">
> 		<attributes>
> 			<attribute name="optional" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="src" output="testbin" path="src/test/resources">
> 		<attributes>
> 			<attribute name="test" value="true"/>
> 			<attribute name="optional" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry combineaccessrules="false" kind="src" path="/base">
> 		<attributes>
> 			<attribute name="module" value="true"/>
> 			<attribute name="add-exports" value="javafx.base/com.sun.javafx.property=javafx.graphics:javafx.base/test.javafx.collections=javafx.graphics:javafx.base/test.util.memory=javafx.graphics"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="con" path="org.eclipse.jdt.junit.JUNIT_CONTAINER/5">
> 		<attributes>
> 			<attribute name="test" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
> 		<attributes>
> 			<attribute name="module" value="true"/>
> 			<attribute name="add-exports" value="java.base/sun.security.util=javafx.graphics"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="output" path="bin"/>
> </classpath>

I've updated the `.classpath` file as shown.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316539556


More information about the openjfx-dev mailing list