RFR: 8301302: Platform preferences API [v5]

[Kevin Rushforth]

On Tue, 5 Sep 2023 19:41:33 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/javafx/application/Application.java line 35:
> 
>> 33: import javafx.css.Stylesheet;
>> 34: import javafx.scene.Scene;
>> 35: import javafx.scene.paint.Color;
> 
> strictly speaking, this file should be unchanged.

Agreed. Now that the user preferences API has been split into a follow-on enhancement, which was a very good idea, there is no reason to change this file.

> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 448:
> 
>> 446:      * by JavaFX when the operating system reports that a platform preference has changed.
>> 447:      *
>> 448:      * @return the {@code Preferences} instance
> 
> minor: make it a link or add a line with a link to the comment itself saying something like
> `Please refer to { @ link Preferences } javadoc for a list of expected preferences.`

I think there is no need to make this a link, since the return type of the method already provides the link.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316363536
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316365683