RFR: 8301302: Platform preferences API [v5]

Andy Goryachev angorya at openjdk.org
Tue Sep 5 20:49:11 UTC 2023


On Tue, 5 Sep 2023 20:19:11 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 448:
>> 
>>> 446:      * by JavaFX when the operating system reports that a platform preference has changed.
>>> 447:      *
>>> 448:      * @return the {@code Preferences} instance
>> 
>> minor: make it a link or add a line with a link to the comment itself saying something like
>> `Please refer to { @ link Preferences } javadoc for a list of expected preferences.`
>
> I think there is no need to make this a link, since the return type of the method already provides the link.

not in Eclipse.  {@code} shows up in monospace font, while {@link} provides the link:

<img width="576" alt="Screenshot 2023-09-05 at 13 45 41" src="https://github.com/openjdk/jfx/assets/107069028/e7e39445-226a-48b2-8154-429e66683243">

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316388067


More information about the openjfx-dev mailing list