RFR: 8313651: Add 'final' keyword to public property methods in controls [v5]

Andy Goryachev angorya at openjdk.org
Thu Sep 7 23:32:16 UTC 2023


On Thu, 7 Sep 2023 22:42:57 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java line 212:
> 
>> 210:     private void checkModifiers(Method m) {
>> 211:         int mod = m.getModifiers();
>> 212:         if (Modifier.isPublic(mod) && !Modifier.isFinal(mod)) {
> 
> Should we also check `protected` methods? If so, that would be something for a follow-up issue.

easy enough to add, and makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1319205285


More information about the openjfx-dev mailing list