RFR: 8313651: Add 'final' keyword to public property methods in controls [v4]

Kevin Rushforth kcr at openjdk.org
Thu Sep 7 23:16:50 UTC 2023


On Tue, 22 Aug 2023 15:15:29 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java line 172:
>> 
>>> 170:     @Test
>>> 171:     public void testMissingFinalMethods() {
>>> 172:         for (Class c: allControlClasses()) {
>> 
>> I think we use a space before `:`. Don't know if it's being enforced. If you change it there are 2 more places.
>
> Adding superfluous spaces increases our carbon footprint ;-)
> Modified the formatter to increase the footprint.

The space before `:` is still missing here.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1319179201


More information about the openjfx-dev mailing list