RFR: 8314906: [testbug] Create behavior tests for text input controls
Andy Goryachev
angorya at openjdk.org
Thu Sep 14 19:18:48 UTC 2023
On Thu, 14 Sep 2023 18:48:39 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Creating the first batch of tests and testing framework that enables writing behavior tests for javafx controls, focusing on key bindings. The idea is to make writing such tests a simple process.
>>
>> This PR deals with the descendants of TextInputControl (TextField, PasswordField, TextArea). Most of the tests are headless, but in some cases (TextArea) a headful test is required because the behavior needs rendered text to function (example: page up / page down / line start / line end and the like).
>>
>> The tests exercise the key bindings registered by the Skin (or, rather the associated Behavior) at least once, and sometimes more than once.
>>
>> Some mappings cannot be tested due to Robot not supporting keypad events (created [JDK-8316307](https://bugs.openjdk.org/browse/JDK-8316307)).
>>
>> In addition, the key bindings are documented in /doc-files/behavior markdown documents.
>
> tests/system/src/test/java/test/javafx/scene/control/behavior/Mod.java line 33:
>
>> 31: * Key Modifiers for use in behavior tests.
>> 32: */
>> 33: public enum Mod {
>
> If this needs to be public (meaning visible to other tests outside this test package), I might recommend a more descriptive name.
the obvious would be KeyModifier, but we already have one in test.com.sun.javafx.scene.control.infrastructure with a different and less convenient semantics.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1221#discussion_r1326414595
More information about the openjfx-dev
mailing list