RFR: 8314906: [testbug] Create behavior tests for text input controls [v3]

Andy Goryachev angorya at openjdk.org
Thu Sep 14 19:44:10 UTC 2023


On Thu, 14 Sep 2023 18:51:33 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - key modifier
>>  - Merge remote-tracking branch 'origin/8314906.behavior.test' into 8314906.behavior.test
>>  - platform util
>
> tests/system/src/test/java/test/util/Util.java line 480:
> 
>> 478:      */
>> 479:     public static boolean isWindows(){
>> 480:         return WINDOWS;
> 
> Are these really needed or can the tests call PlatformUtil directly? If there is a good reason to add them, then they should delegate to PlatformUtil rather than duplicate the functionality.

was able to use PlatformUtils directly after adding 
--add-exports javafx.base/com.sun.javafx=ALL-UNNAMED
to the launch configuration.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1221#discussion_r1326434128


More information about the openjfx-dev mailing list