RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v8]

[Kevin Rushforth]

On Wed, 27 Sep 2023 15:19:47 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> I was also having second thoughts - 2 reviewers might be insufficient. 3 is better. thanks!

My comment crossed yours in the ether (I responded too quickly before seeing that you had bumped the reviewers and requested a CSR). I put it back to 2 for now.

> modules/javafx.graphics/src/main/java/javafx/scene/input/InputMethodRequests.java line 61:
> 
>> 59:      * inserted.
>> 60:      *
>> 61:      * @param offset the offset within the composed text, if there is
> 
> how can an int be null?

The return type is Point2D, not int.

But I'm glad you commented on it. I hadn't looked at this PR at all. Adding a method to a public interface is an API change, so at a minimum needs a CSR. More problematic is that since this isn't a default method, it is an incompatible change -- at least if any class outside of the JavaFX runtime were to implement it.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1080#issuecomment-1737615656
PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1338772357