RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v8]

Wed Sep 27 15:23:33 UTC 2023

On Wed, 27 Sep 2023 15:12:58 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/input/InputMethodRequests.java line 61:
>> 
>>> 59:      * inserted.
>>> 60:      *
>>> 61:      * @param offset the offset within the composed text, if there is
>> 
>> how can an int be null?
>
> The return type is Point2D, not int.
> 
> But I'm glad you commented on it. I hadn't looked at this PR at all. Adding a method to a public interface is an API change, so at a minimum needs a CSR. More problematic is that since this isn't a default method, it is an incompatible change -- at least if any class outside of the JavaFX runtime were to implement it.

I copied it from `getTextLocation`, but you're right.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1338775497