RFR: 8324939: Editable TableView loses focus after commit [v2]

Jose Pereda jpereda at openjdk.org
Wed Apr 3 19:54:20 UTC 2024


On Thu, 28 Mar 2024 11:20:23 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address feedback from reviewer
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.java line 2362:
> 
>> 2360:         assertTrue(treeView.isFocused());
>> 2361: 
>> 2362:         VirtualFlowTestUtils.BLOCK_STAGE_LOADER_DISPOSE = true;
> 
> This should not be needed since you are creating a `stageLoader` above. This seems to be only used when no `stageLoader` was created before

Thanks @Maran23, I've removed it now from the added tests.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1411#discussion_r1550359262


More information about the openjfx-dev mailing list