RFR: 8324939: Editable TableView loses focus after commit [v2]

[Marius Hanl]

On Wed, 3 Apr 2024 19:51:08 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.java line 2362:
>> 
>>> 2360:         assertTrue(treeView.isFocused());
>>> 2361: 
>>> 2362:         VirtualFlowTestUtils.BLOCK_STAGE_LOADER_DISPOSE = true;
>> 
>> This should not be needed since you are creating a `stageLoader` above. This seems to be only used when no `stageLoader` was created before
>
> Thanks @Maran23, I've removed it now from the added tests.

> I wish there was a more reliable way of implementing getCell() without resorting to undocumented flags like BLOCK_STAGE_LOADER_DISPOSE.

There is, just add the virtual container to a Stage. Since the cells are only created inside the skin, which is only created when the component is inside the scene tree.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1411#discussion_r1551054299