RFR: 8328577: Toolbar's overflow button overlaps the items [v5]

[eduardsdv]

On Mon, 15 Apr 2024 15:10:42 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> eduardsdv has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - JDK-8328577: Update comment
>>  - JDK-8328577: Bind style related properties
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java line 573:
> 
>> 571:         overflowBox.idProperty().bind(box.idProperty());
>> 572:         overflowBox.getStyleClass().setAll(box.getStyleClass());
>> 573:         box.getStyleClass().addListener((ListChangeListener<? super String>) change -> overflowBox.getStyleClass().setAll(change.getList()));
> 
> I think what you need here (and below) is `Bindings.bindContent(List, ObservableList)`

Good suggestion

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1434#discussion_r1565996530