RFR: 8328577: Toolbar's overflow button overlaps the items [v5]
eduardsdv
duke at openjdk.org
Mon Apr 15 15:45:00 UTC 2024
On Mon, 15 Apr 2024 15:24:06 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> eduardsdv has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - JDK-8328577: Update comment
>> - JDK-8328577: Bind style related properties
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java line 575:
>
>> 573: box.getStyleClass().addListener((ListChangeListener<? super String>) change -> overflowBox.getStyleClass().setAll(change.getList()));
>> 574: overflowBox.getStylesheets().setAll(box.getStylesheets());
>> 575: box.getStylesheets().addListener((ListChangeListener<? super String>) change -> overflowBox.getStylesheets().setAll(change.getList()));
>
> this is interesting.
>
> isn't `overflowBox` a sibling of `box`, having the same parent, and therefore inheriting the same set of stylesheets from the parent `Scene`?
In addition to those from the scene, each ``Parent`` can have its own stylesheets.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1434#discussion_r1566002787
More information about the openjfx-dev
mailing list