RFR: 8328577: Toolbar's overflow button overlaps the items [v6]

eduardsdv duke at openjdk.org
Tue Apr 16 15:57:02 UTC 2024


On Mon, 15 Apr 2024 15:49:04 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> eduardsdv has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8328577: Refactor and fix binding of style related properties
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java line 575:
> 
>> 573:         Bindings.bindContent(overflowBox.getStyleClass(), box.getStyleClass());
>> 574:         Bindings.bindContent(overflowBox.getStylesheets(), box.getStylesheets());
>> 575:         box.getPseudoClassStates().addListener((SetChangeListener<? super PseudoClass>) change -> {
> 
> you can also use Bindings.bindContent(Set,ObservableSet)

Done. See [92921e3](https://github.com/openjdk/jfx/pull/1434/commits/92921e36987e3cd1cfe78c17b464547aa73d241e)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1434#discussion_r1567603745


More information about the openjfx-dev mailing list