RFR: 8328577: Toolbar's overflow button overlaps the items [v6]

Andy Goryachev angorya at openjdk.org
Tue Apr 16 16:00:59 UTC 2024


On Tue, 16 Apr 2024 15:54:11 GMT, eduardsdv <duke at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java line 575:
>> 
>>> 573:         Bindings.bindContent(overflowBox.getStyleClass(), box.getStyleClass());
>>> 574:         Bindings.bindContent(overflowBox.getStylesheets(), box.getStylesheets());
>>> 575:         box.getPseudoClassStates().addListener((SetChangeListener<? super PseudoClass>) change -> {
>> 
>> you can also use Bindings.bindContent(Set,ObservableSet)
>
> Done. See [92921e3](https://github.com/openjdk/jfx/pull/1434/commits/92921e36987e3cd1cfe78c17b464547aa73d241e)

line 575 still uses a listener instead of Bindings.bindContent(**Set,ObservableSet**)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1434#discussion_r1567609882


More information about the openjfx-dev mailing list