RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v24]
Ambarish Rapte
arapte at openjdk.org
Mon Apr 29 17:56:15 UTC 2024
On Mon, 29 Apr 2024 15:47:54 GMT, Oliver Kopp <duke at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java line 104:
>>
>>> 102: int length = text.length();
>>> 103: start = Utils.clamp(0, start, length);
>>> 104: end = Utils.clamp(start, end, length);
>>
>> This is only cleanup and not required for this fix.
>
> I applied the software engineering principle to leave the code cleaner than seen. (Martin Fowler et all)
>
> Should I revert this?
Sorry for not being clear. I just wanted to point out that it is not required for the issue fix.
Please don't revert. This looks better.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1583488561
More information about the openjfx-dev
mailing list