RFR: 8332895: Support interpolation for backgrounds and borders [v3]

Michael Strauß mstrauss at openjdk.org
Sun Aug 4 18:58:14 UTC 2024


On Fri, 2 Aug 2024 16:02:43 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix since tag
>>  - adjust table styling
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/paint/StopListTest.java line 264:
> 
>> 262:                 new Stop(1, color2)),
>> 263:             res);
>> 264:         }
> 
> Do you think any other combinations should be added, for completeness sake?
> 
> For example, let's consider two lists with 2 points each.  We might want to test scenarios:
> 
> 
> --
>      --
> 
> --|
>   |--
> 
> ---
>  ---
> 
> ----|
>  ---|
> 
> ------
>   --
> 
>   |-----
>   |--
> 
>   |---|
>   |---|
> 
>     |--
>   --|
> 
>      ---
> --
> 
> 
> and also have the two lists swapped maybe?
> 
> what do you think?

I've added another test, which gives us 100% coverage for all code paths. I would consider this complete.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1703348960


More information about the openjfx-dev mailing list