RFR: 8325445: [macOS] Colors are not displayed in sRGB color space [v5]
Andy Goryachev
angorya at openjdk.org
Mon Aug 5 15:05:41 UTC 2024
On Sat, 3 Aug 2024 14:33:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review feedback: floating point precision in test, ensure unsigned int handling in Robot
>
> tests/system/src/test/java/test/robot/javafx/scene/SRGBTest.java line 218:
>
>> 216: // colors but they might both be working in the wrong space. We use an
>> 217: // AWT Robot to verify that they are working in sRGB.
>> 218: @Test
>
> This test needs a timeout value to avoid hanging the test job on Linux with Wayland. See [JDK-8335468](https://bugs.openjdk.org/browse/JDK-8335468). I recommend:
>
>
> @Test(timeout = 15000)
Maybe there is a way to skip the test on Wayland until we find a proper solution?
Asking for completeness sake - simply adding a timeout works too.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1473#discussion_r1704255339
More information about the openjfx-dev
mailing list