RFR: 8338016: SplitMenuButton constructors should match MenuButton
Andy Goryachev
angorya at openjdk.org
Wed Aug 14 17:25:06 UTC 2024
On Wed, 14 Aug 2024 16:21:48 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Adding SplitMenuButton constructors matching MenuButton:
>>
>> - public SplitMenuButton(String text)
>> - public SplitMenuButton(String text, Node graphic)
>> - public SplitMenuButton(String text, Node graphic, MenuItem... items)
>
> modules/javafx.controls/src/main/java/javafx/scene/control/SplitMenuButton.java line 123:
>
>> 121: * @param text the text to display on the menu button
>> 122: * @param graphic the graphic to display on the menu button
>> 123: * @param items The items to display in the popup menu.
>
> Minor: description should start with a small letter and not end with a dot.
that was lifted straight from MenuButton... but you are right of course.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1535#discussion_r1717292365
More information about the openjfx-dev
mailing list