RFR: 8338016: SplitMenuButton constructors should match MenuButton [v2]

Michael Strauß mstrauss at openjdk.org
Thu Aug 15 16:55:55 UTC 2024


On Thu, 15 Aug 2024 14:46:23 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Adding SplitMenuButton constructors matching MenuButton:
>> 
>> - public SplitMenuButton(String text)
>> - public SplitMenuButton(String text, Node graphic)
>> - public SplitMenuButton(String text, Node graphic, MenuItem... items)
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   tests

modules/javafx.controls/src/test/java/test/javafx/scene/control/SplitMenuButtonTest.java line 34:

> 32: import org.junit.Test;
> 33: 
> 34: import static org.junit.Assert.*;

Since you're modifying this file significantly, you could also use the JUnit5 imports.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1535#discussion_r1718701002


More information about the openjfx-dev mailing list