RFR: 8338016: SplitMenuButton constructors should match MenuButton [v2]

[Andy Goryachev]

On Thu, 15 Aug 2024 16:53:47 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/SplitMenuButtonTest.java line 34:
> 
>> 32: import org.junit.Test;
>> 33: 
>> 34: import static org.junit.Assert.*;
> 
> Since you're modifying this file significantly, you could also use the JUnit5 imports.

I think that would be out of scope for this PR.

We are considering updating tests to junit5 in bulk at some point, but I suspect it's a fairly low priority, unless we need to address something like https://bugs.openjdk.org/browse/JDK-8328629

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1535#discussion_r1718724352