New CSS parser for JavaFX

[Andy Goryachev]

Well, I don't think we should dissuade anyone from discussing a possible improvement from the very beginning, especially if they are trying to address a pain point.

Though Kevin is right: CSS is a complicated subsystem, and attempting to change it, or worse, rewrite it, requires enormous effort - not only for development, but also for reviewing and most of all, testing.  I also have little confidence in the CSS "spec" - not only it's a moving target, but the github shows 3.3k issues https://github.com/w3c/csswg-drafts/issues .  Granted, not all of them might be applicable, but it certainly does not help.

-andy




From: openjfx-dev <openjfx-dev-retn at openjdk.org> on behalf of Kevin Rushforth <kevin.rushforth at oracle.com>
Date: Monday, August 26, 2024 at 11:52
To: openjfx-dev at openjdk.org <openjfx-dev at openjdk.org>
Subject: Re: New CSS parser for JavaFX
Lots of things might be good ideas. I'm rather skeptical of the cost / benefit of implementing a new CSS parser. This would be a large effort and run a significant risk of regression, especially since CSS is a fragile area (although parsing less so than the runtime CSS processing).

-- Kevin

On 8/26/2024 10:24 AM, Andy Goryachev wrote:
Michael:

This might be a good idea.  A few questions:


  *   can we create stylesheets programmatically without parsing (i.e. construct the token tree directly)?
  *   would it be possible to add a diagnostic (at the moment of applyCSS()) to show the actual rule(s) being used?
  *   are we going to track the evolution of https://www.w3.org/TR/css-syntax-3/ "spec"?
  *   are we going to clarify the w3 "spec" (what is the value of "EOF code point"?)?
  *   are there incompatibilities between web-style CSS and FX-style CSS?
  *   what is the testing strategy?

Thank you

-andy

From: openjfx-dev <openjfx-dev-retn at openjdk.org><mailto:openjfx-dev-retn at openjdk.org> on behalf of Michael Strauß <michaelstrau2 at gmail.com><mailto:michaelstrau2 at gmail.com>
Date: Sunday, August 25, 2024 at 20:45
To: openjfx-dev <openjfx-dev at openjdk.org><mailto:openjfx-dev at openjdk.org>
Subject: New CSS parser for JavaFX
I've written up a proposal to implement a new CSS parser for JavaFX:
https://gist.github.com/mstr2/f416996caf48e11193f0b6a5883a3926

The goal is not add new features at this point, but to resolve some
long-standing issues with the existing CSS parsing (though if you read
carefully, you might spot a new feature).

I'm interested in your opinion whether this is a good idea to move forward.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240826/c06e70a5/attachment-0001.htm>