RFR: 8301121: RichTextArea Control (Incubator) [v50]

Andy Goryachev angorya at openjdk.org
Tue Dec 3 16:21:02 UTC 2024


On Mon, 2 Dec 2024 16:12:14 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   whitespace
>
> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/util/ListenerHelper.java line 85:
> 
>> 83:     public static ListenerHelper get(SkinBase<?> skin) {
>> 84:         return accessor.apply(skin);
>> 85:     }
> 
> I think ideally, a get method should not do any processing but just return the desired value/object.

not sure what you mean, it's a standard helper/accessor pattern - there is no "processing" involved.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1868023324


More information about the openjfx-dev mailing list