RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v2]

[Marius Hanl]

On Wed, 4 Dec 2024 19:59:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Marius Hanl has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java line 141:
> 
>> 139:                 fixedCellSizeEnabled = fixedCellSize > 0.0;
>> 140: 
>> 141:                 if (fixedCellSizeEnabled) {
> 
> is this PR going to clash with #1645 ?

Not clash, but there will be merge conflicts that are easy to solve

> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java line 228:
> 
>> 226:         if (disclosureNodeDirty) {
>> 227:             updateDisclosureNodeAndGraphic();
>> 228:             disclosureNodeDirty = false;
> 
> shouldn't `disclosureNodeDirty = false;` be moved to `updateDisclosureNodeAndGraphic();` ?
> here and in L257, L216

Could be an idea. I will check. I just tried to not make to many changes, but this might be an easy one.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1644#discussion_r1870979053
PR Review Comment: https://git.openjdk.org/jfx/pull/1644#discussion_r1870979872