RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v2]

[Marius Hanl]

On Thu, 5 Dec 2024 09:24:13 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java line 228:
>> 
>>> 226:         if (disclosureNodeDirty) {
>>> 227:             updateDisclosureNodeAndGraphic();
>>> 228:             disclosureNodeDirty = false;
>> 
>> shouldn't `disclosureNodeDirty = false;` be moved to `updateDisclosureNodeAndGraphic();` ?
>> here and in L257, L216
>
> Could be an idea. I will check. I just tried to not make to many changes, but this might be an easy one.

Checked the code, that is a safe improvement, so will do.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1644#discussion_r1876896331