RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v2]

[Andy Goryachev]

On Tue, 10 Dec 2024 21:56:07 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkinBase.java line 421:
>> 
>>> 419:             } else {
>>> 420:                 width = tableCell.prefWidth(height);
>>> 421:                 // we only add/remove to the scenegraph if the fixed cell
>> 
>> are you sure this is correct?
>> the tableCell is added in L343 only if `fixedCellSize > 0`
>> the removal in L424 misses that logic
>
> Yes, IntelliJ actually gave me the hint.
> `isVisible` can only be `false`, when a `fixedCellSize` is set. So the else branch can only ever be executed when `fixedCellSize > 0`

it's hard to tell (for me): there are just too many conditions: isColumnParticallyOrFullVisible(), if parent == null...

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1645#discussion_r1878954208