RFR: 8301121: RichTextArea Control (Incubator) [v61]

[Andy Goryachev]

On Thu, 12 Dec 2024 16:21:04 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 83 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - legal
>>  - unicode license
>>  - add handler
>>  - review comments
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - clamp
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - review comments
>>  - review comments
>>  - ... and 73 more: https://git.openjdk.org/jfx/compare/b76c05b9...e5814b21
>
> modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/InputMap.java line 71:
> 
>> 69:  * When such a mapping exists, the found function tag is matched to a function registered either by
>> 70:  * the application or by the skin.
>> 71:  * This mechanism allows for customizing the key mappings and the underlying functions independently and separately.
> 
> Additionally, the `register(KeyBinding,Runnable)` method allows mapping to a function directly, bypassing the function tag. You probably want to document this. You might also say that a `KeyBinding` is only mapped to a single value: either a FunctionTag or a Runnable (last one wins).

good point!  it's a bit more complex - the mapping done via the InputMap takes precedence over skin mappings (which typically use FunctionTags), this fact is documented in `register(KeyBinding k, Runnable function)` method.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1882849221