RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations

[Andy Goryachev]

On Wed, 14 Feb 2024 20:52:44 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java line 2639:
>> 
>>> 2637:         StageLoader sl = new StageLoader(treeTableView);
>>> 2638: 
>>> 2639:         assertEquals(18, rt_31200_count);
>> 
>> magic number... should we explain why exactly 18 ?
>
> It is the count, how often update item was called. 
> That it got smaller shows, that we call it less often, as the item was not changed (which is a good thing).
> That also matches with your observation, which is the expected output here.
> 
> I saw that this was changed for some tests in https://github.com/openjdk/jfx/pull/863, we also can do something similar here as well.

on second thought, this is ok as is - I asked because the code is not testing a specific requirement.
The second `assertEquals(18)` might be testing a specific requirement - that the count has not changed, right?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1360#discussion_r1490064468