RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations

Marius Hanl mhanl at openjdk.org
Thu Feb 15 12:11:01 UTC 2024


On Wed, 14 Feb 2024 21:01:59 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> It is the count, how often update item was called. 
>> That it got smaller shows, that we call it less often, as the item was not changed (which is a good thing).
>> That also matches with your observation, which is the expected output here.
>> 
>> I saw that this was changed for some tests in https://github.com/openjdk/jfx/pull/863, we also can do something similar here as well.
>
> on second thought, this is ok as is - I asked because the code is not testing a specific requirement.
> The second `assertEquals(18)` might be testing a specific requirement - that the count has not changed, right?

Yes, as far as I can see.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1360#discussion_r1490914400


More information about the openjfx-dev mailing list