RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v2]

[Andy Goryachev]

On Fri, 12 Jan 2024 05:16:33 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> @karthikpandelu , the more I think about it, the less I like the idea of overloading (textRunStart and curRunStart).
>> what if things will change in the future?
>> 
>> I think it'll be much cleaner to pass a boolean forTextFlow (or forText) or some such.  we have to compute such a boolean flag anyway, why not just pass it?
>
> Are you suggesting to pass boolean as parameter in addition to textRunStart and curRunStart? If that is the case then yes I think it would be better.

that's right, something like this:


public Hit getHitInfo(float x, float y, String text, int textRunStart, int curRunStart, boolean forTextFlow);

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1450629952