RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v2]

Karthik P K kpk at openjdk.org
Fri Jan 12 05:19:32 UTC 2024


On Fri, 12 Jan 2024 00:18:38 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> I changed 0 to -1 to figure out if the `getHitInfo` in `PrismTextLayout` is invoked by `Text` or `TextFlow`.
>> Added comment regarding this in `com.sun.javafx.scene.tex.TextLayout`.
>
> @karthikpandelu , the more I think about it, the less I like the idea of overloading (textRunStart and curRunStart).
> what if things will change in the future?
> 
> I think it'll be much cleaner to pass a boolean forTextFlow (or forText) or some such.  we have to compute such a boolean flag anyway, why not just pass it?

Are you suggesting to pass boolean as parameter in addition to textRunStart and curRunStart? If that is the case then yes I think it would be better.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1449853445


More information about the openjfx-dev mailing list