RFR: JDK-8323543: NPE when table items are set to null [v5]

Marius Hanl mhanl at openjdk.org
Sat Jan 13 11:07:32 UTC 2024


On Thu, 11 Jan 2024 20:10:19 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> I think the problem is that we are trying to address two issues in one PR - the fix and migration to junit5. It might be better to go back one commit (but keep the most recent changes on a separate branch), convert the fix to use junit4 and submit the fix in this PR.

Sure, just FYI that there is nothing like `assertDoesNotThrow` for JUnit4.
What I did in the past is to at least write a comment, so we can easily add/convert that later on.
See also my PR in the past:
https://github.com/openjdk/jfx/pull/557
More specific:
https://github.com/openjdk/jfx/pull/557/files#diff-ea6f98c080f3abde83c8de64cd1b026b727bd5998cf6e0e57dde857f0e3e541eR353
cc @EstelonAgarwaen, I would recommend doing it the same way I did above and stash the JUnit 5 migration, as @andy-goryachev-oracle mentioned.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1329#issuecomment-1890418941


More information about the openjfx-dev mailing list