RFR: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html

[Kevin Rushforth]

On Thu, 18 Jan 2024 03:51:28 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

> Issue: constructor Path(Path) which takes another Path object fails to draw on canvas html.
> Solution: copy the old path while creating a new Path object from the existing Path that is already created with the same canvas rendering context.

The fix looks reasonable, although there is now an unused variable, and I have a suggestion for making it clearer.

I verified that the test fails on Windows without your fix. I will rebuild WebKit and verify that it passes with your fix.

modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/PathJava.cpp line 123:

> 121:     auto platformPathCopy = createEmptyPath();
> 122: 
> 123:     RefPtr<RQRef> pathCopy(copyPath(platformPath()));

The `platformPathCopy` local variable is now unused and can be removed. Better still, you could make the following change and then revert the name change in the `create` method where it is used.


    RefPtr<RQRef> platformPathCopy(copyPath(platformPath()));

-------------

PR Review: https://git.openjdk.org/jfx/pull/1339#pullrequestreview-1830100123
PR Review Comment: https://git.openjdk.org/jfx/pull/1339#discussion_r1457695482