RFR: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html

Kevin Rushforth kcr at openjdk.org
Thu Jan 18 20:59:24 UTC 2024


On Thu, 18 Jan 2024 03:51:28 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

> Issue: constructor Path(Path) which takes another Path object fails to draw on canvas html.
> Solution: copy the old path while creating a new Path object from the existing Path that is already created with the same canvas rendering context.

The test passes with your fix.

There are a few unused imports in the test that you can remove.

modules/javafx.web/src/test/java/test/javafx/scene/web/PathContructorTest.java line 33:

> 31: import java.awt.image.BufferedImage;
> 32: import java.util.Base64;
> 33: import javafx.scene.web.WebEngineShim;

All of these imports are unused and can be removed.

modules/javafx.web/src/test/java/test/javafx/scene/web/PathContructorTest.java line 36:

> 34: 
> 35: 
> 36: import org.junit.After;

Unused import.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1339#pullrequestreview-1830534336
PR Review Comment: https://git.openjdk.org/jfx/pull/1339#discussion_r1457964551
PR Review Comment: https://git.openjdk.org/jfx/pull/1339#discussion_r1457964890


More information about the openjfx-dev mailing list