RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

[Jose Pereda]

On Mon, 29 Jan 2024 03:28:51 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Added a utility method to run code on the FX thread if it's not already, and changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update tests

tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTest.java line 1:

> 1: /*

Don't remove license

tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTimerTest.java line 1:

> 1: /*

Don't remove license

tests/system/src/test/java/test/com/sun/javafx/animation/SynchronisityTest.java line 1:

> 1: package test.com.sun.javafx.animation;

Add license

tests/system/src/test/java/test/com/sun/javafx/animation/SynchronisityTest.java line 20:

> 18: 
> 19: // Based on https://bugs.openjdk.org/browse/JDK-8159048
> 20: public class SynchronisityTest extends Application {

shouldn't it be `SynchronicityTest`?

tests/system/src/test/java/test/com/sun/javafx/animation/SynchronisityTest.java line 53:

> 51:     private AtomicBoolean failed = new AtomicBoolean(false);
> 52:     private CountDownLatch waiter = new CountDownLatch(1);
> 53:     private ExecutorService executor = Executors.newCachedThreadPool();

These can be `final`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1469281637
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1469281296
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1469278053
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1469307640
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1469295387