RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

Kevin Rushforth kcr at openjdk.org
Mon Jan 29 13:21:50 UTC 2024


On Mon, 29 Jan 2024 09:33:35 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update tests
>
> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronisityTest.java line 20:
> 
>> 18: 
>> 19: // Based on https://bugs.openjdk.org/browse/JDK-8159048
>> 20: public class SynchronisityTest extends Application {
> 
> shouldn't it be `SynchronicityTest`?

Yes, or maybe `SynchronizationTest`.

More importantly, the main test class should not extend `Application`. See [JDK-8234876](https://bugs.openjdk.org/browse/JDK-8234876).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1469546192


More information about the openjfx-dev mailing list