RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

[Jose Pereda]

On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Added a utility method to run code on the FX thread if it's not already, and changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update tests

modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line 909:

> 907:      * This method must be run on the JavaFX Application Thread.
> 908:      *
> 909:      * @see #playFromStartImpl(String)

there is no such symbol. Do you mean `playFrom(String)`?

modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line 953:

> 951:      * This method must be run on the JavaFX Application Thread.
> 952:      *
> 953:      * @see #playFromStartImpl(Duration)

there is no such symbol. Do you mean `playFrom(Duration)`?

modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line 989:

> 987:      * This method must be run on the JavaFX Application Thread.
> 988:      *
> 989:      * @see #playFromStartImpl()

Do you mean `playFromStart()`?

tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.

Copyright header should keep 2023, even if it is almost completely changed

tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTimerTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.

Same, copyright header should keep 2023, even if it is almost completely changed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1470098558
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1470099369
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1470090981
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1470088051
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1470088333