Platform preferences theme detection

[Andy Goryachev]

Are you sure it wasn’t change in some version of Windows 10 or between 10 and 11?  I vaguely recall testing light/dark mode switch on Windows 11.

-andy



From: openjfx-dev <openjfx-dev-retn at openjdk.org> on behalf of Michael Strauß <michaelstrau2 at gmail.com>
Date: Monday, January 29, 2024 at 14:09
To:
Cc: openjfx-dev at openjdk.org <openjfx-dev at openjdk.org>
Subject: Re: Platform preferences theme detection
I see that the names of the platform mappings defined in WinApplication::getPlatformKeyMappings() are simply wrong ("Windows.UIColor.ForegroundColor" instead of "Windows.UIColor.Foreground"), so the platform mappings are not applied to the properties.

That's quite surprising, and it's a change that must have slipped into the feature at a very late stage during development, so that it went unnoticed by all reviewers.
I'll file a bug and prepare a fix for this issue.


On Mon, Jan 29, 2024 at 10:45 PM Christopher Schnick <crschnick at xpipe.io<mailto:crschnick at xpipe.io>> wrote:

Hello Michael,

I took a look at the implementation and tried to find the issue. From what I can see, the mappings returned are correct:

[cid:ii_18d573d4eaed3eee5091]

but it seems like they are somehow not applied the PreferencesProperties:

[cid:ii_18d573d4eaed3fcfc8a2]

Let me know whether I can help with anything to debug this issue.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240129/b6f80a57/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: img1.png
Type: image/png
Size: 39755 bytes
Desc: img1.png
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240129/b6f80a57/img1-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: img2.png
Type: image/png
Size: 36000 bytes
Desc: img2.png
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240129/b6f80a57/img2-0001.png>